Skip to content

Update website link in About pane - #4325

Merged
steipete merged 4 commits into
steipete:mainfrom
elijahfriedman:move-website
Oct 8, 2026
Merged

Update website link in About pane#4325
steipete merged 4 commits into
steipete:mainfrom
elijahfriedman:move-website

Conversation

@elijahfriedman

@elijahfriedman elijahfriedman commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Updated link in settings to go to codexbar.app instead of steipete.me.

Verification

  • Built successfully
  • make check ran with no issues
  • make test ran with no issues

Screen recording

Screen.Recording.2026-10-07.at.9.10.25.AM.mov

@clawsweeper

clawsweeper Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. proof: 🎥 video Contributor real behavior proof includes video or recording evidence. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: needs maintainer proof decision A ClawSweeper-authored PR needs a maintainer proof capture or override decision. labels Oct 7, 2026
@clawsweeper

clawsweeper Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex review: needs real behavior proof before merge. Reviewed October 7, 2026, 9:27 PM ET / October 8, 2026, 01:27 UTC (Revision 3).

ClawSweeper review

What this changes

This PR points the About pane’s Website link to codexbar.app and adds documentation, a release note, and source-based tests.

Example: Click Website in Settings → About

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) The production edit is useful and correct; proof inspection remains unresolved and the added tests provide little value.
Proof confidence 🦐 gold shrimp (3/6) Needs stronger real behavior proof before merge: A contributor recording is supplied for the real About-pane Website click, but its observed browser result could not be inspected: ffprobe is unavailable and web fallback returned a cache miss. This remains reviewer-side inspection work, so replacement contributor evidence is not presently warranted. No stored-data contract changes. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Patch quality 🦐 gold shrimp (3/6) No actionable review findings were identified.

Product

Kind: Preference · Worth it: Yes · Fix scope: Complete
User problem: The About pane’s Website link takes users to the developer’s personal website rather than CodexBar’s project website.
Reason: This changes an intentional destination rather than repairing browser-opening behavior. The area owner explicitly supported the project-domain destination, and the navigation benefit exceeds the tiny production change.

Merge readiness

⛔ Blocked before merge - 2 items remain

Keep this PR open: the small, owner-supported improvement remains useful and is absent from current main. Real behavior proof still needs verification before merge; the existing recording could not be inspected because of reviewer-side tooling limitations.

Priority: P3
Reviewed head: 04556b366e3531dc3bac0f9903fa683ef95a6bb4

Before merge

  • Resolve real behavior proof assessment - Needs stronger real behavior proof before merge: A contributor recording is supplied for the real About-pane Website click, but its observed browser result could not be inspected: ffprobe is unavailable and web fallback returned a cache miss. This remains reviewer-side inspection work, so replacement contributor evidence is not presently warranted. No stored-data contract changes. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
  • Complete next step (P2) - Complete reviewer-side inspection of the supplied recording and confirm that clicking Website opens codexbar.app.

Findings

None.

Tests

  • Low-value test Tests/CodexBarTests/AboutWebsiteTests.swift: website link matches the published project domain: Parses source spelling with a regular expression instead of exercising the actual Website click; remove this brittle implementation assertion.
  • Low-value test Tests/CodexBarTests/AboutWebsiteTests.swift: about links render without opening a browser: Normally returns without exercising anything and otherwise renders a synthetic row without testing browser navigation; remove this optional proof-generation test.
  • Missing end-to-end proof: The supplied recording’s Website click and resulting browser destination remain unverified because local video preparation and web fallback failed. No base-fail/head-pass execution was performed in this read-only review.
Agent review details

How this fits together

CodexBar’s About pane displays application information and links. Clicking a link passes its configured URL to macOS to open in the browser.

flowchart LR
 A[Settings window] --> B[About pane]
 B --> C[Website click]
 C --> D[Configured project URL]
 D --> E[macOS opens browser]
 E --> F[CodexBar website]
Loading

Technical review

Best possible solution:

Use the published project website for the About link, preserve the existing browser-opening action, and avoid source-spelling or synthetic-render tests for this literal change.

Do we have a high-confidence way to reproduce the issue?

Not applicable as a runtime defect: current main visibly configures the Website link to steipete.me, establishing the existing behavior directly.

Is this the best way to solve the issue?

Yes, changing the existing URL literal is the narrowest solution and has area-owner support; the additional source-based tests are unnecessary.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 844b0e19bbbb.

Provenance checked

  • Sources/CodexBar/PreferencesAboutPane.swift: Website link changes intended behavior with a stated reason (Redesign settings as a System Settings-style split view #1853: The settings redesign grouped the existing About links into a native form; its stated rationale did not specifically explain the personal-site destination.)

Testing

Proof path: unit tests only. Added test files: 1.

Security

None.

Evidence

What I checked:

Likely related people:

  • unknown: The claimed source-line change could not be verified from bounded local history. (role: source history unknown; confidence: low)

Review metrics

Metric Value Why it matters
Production and test growth production +1/-1 lines; tests +52 lines The production change is appropriately small, while the added source-parsing and optional rendering tests provide little behavioral confidence.

Labels

Label changes:

  • add status: needs maintainer proof decision: A ClawSweeper-authored PR needs a maintainer proof capture or override decision. Needs stronger real behavior proof before merge: A contributor recording is supplied for the real About-pane Website click, but its observed browser result could not be inspected: ffprobe is unavailable and web fallback returned a cache miss. This remains reviewer-side inspection work, so replacement contributor evidence is not presently warranted. No stored-data contract changes. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
  • remove status: 📣 needs proof: Current PR status label is status: needs maintainer proof decision.

Label justifications:

  • P3: Updating an About-pane destination is low-risk navigation polish.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🦐 gold shrimp.
  • status: needs maintainer proof decision: A ClawSweeper-authored PR needs a maintainer proof capture or override decision. Needs stronger real behavior proof before merge: A contributor recording is supplied for the real About-pane Website click, but its observed browser result could not be inspected: ffprobe is unavailable and web fallback returned a cache miss. This remains reviewer-side inspection work, so replacement contributor evidence is not presently warranted. No stored-data contract changes. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
  • proof: 🎥 video: Contributor real behavior proof includes video or recording evidence.

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Inspect the existing recording to confirm the Website click opens codexbar.app.
  • Remove the source-spelling and optional synthetic-render tests.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only; repair and merge need explicit maintainer commands such as @clawsweeper autofix or @clawsweeper automerge.

History

Review history (2 earlier review cycles)
  • reviewed 2026-10-07T13:19:08.325Z sha f2e8da6 :: needs real behavior proof before merge. :: none
  • reviewed 2026-10-08T00:56:15.660Z sha b18032b :: needs real behavior proof before merge. :: none

@steipete
fix(settings): verify the About website destination
b18032b 
Merge the reviewed main baseline without rewriting the contributor commit.
Check the Website URL against the published CNAME, add a synthetic link-row
render, and document the corrected destination with credit for steipete#4325.
@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: needs maintainer proof decision A ClawSweeper-authored PR needs a maintainer proof capture or override decision. labels Oct 8, 2026
@clawsweeper clawsweeper Bot added status: needs maintainer proof decision A ClawSweeper-authored PR needs a maintainer proof capture or override decision. and removed status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Oct 8, 2026
@steipete
steipete merged commit 4614415 into steipete:main Oct 8, 2026
8 of 9 checks passed
@steipete

steipete commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Thanks @elijahfriedman! Merged in 4614415: the About pane now links to the current website address, matching the README and site metadata. Ships in the next release.

@elijahfriedman
elijahfriedman deleted the move-website branch October 8, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. proof: 🎥 video Contributor real behavior proof includes video or recording evidence. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: needs maintainer proof decision A ClawSweeper-authored PR needs a maintainer proof capture or override decision.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elijahfriedman @steipete